Email modification after creation #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lchrusciel
approved these changes
Jan 2, 2023
Zales0123
force-pushed
the
email-modification-after-creation
branch
2 times, most recently
from
66d59e7
to
8f3cb39
Compare
lchrusciel
approved these changes
Jan 3, 2023
GSadee
approved these changes
Jan 3, 2023
|
The base of this pull-request was changed, you need fetch and reset your local branch Unless you added new commits (to this branch) locally that you did not push yet, Feel free to ask for assistance when you get stuck 👍 |
NoResponseMate
approved these changes
Jan 3, 2023
GSadee
force-pushed
the
email-modification-after-creation
branch
from
898cb97
to
b7b4480
Compare
GSadee
approved these changes
Jan 6, 2023
Zales0123
force-pushed
the
email-modification-after-creation
branch
from
b7b4480
to
d837ca7
Compare
GSadee
approved these changes
Jan 9, 2023
|
Thank you, Mateusz! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the default configuration-based email creation is sufficient in most cases, it's not uncommon for one to need it conditional or dynamic in any other way. I thought about modifying the
EmailProvider::getEmail(string $code)method to accept thearray $dataargument, but thought it would be more extendible to provide a set of modifiers services, that could be easily implemented in the application. Maybe it should also contain thesupport(EmailInterface $email): boolmethod, to not force checking the email code inside themodifymethod 🤔Let me know what you think about such a feature 🖖 I will add some documentation to this feature if we would like to proceed with it 🫡